Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix unstable test in resource group #44918

Merged
merged 1 commit into from
Jun 25, 2023
Merged

tests: fix unstable test in resource group #44918

merged 1 commit into from
Jun 25, 2023

Conversation

CabinfeverB
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #44883

Problem Summary:

What is changed and how it works?

introduce EventuallyMustQueryAndCheck into TestKit to assert query eventually

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@CabinfeverB
fix unstable test
8cd5841 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2023
@CabinfeverB
Copy link
Contributor Author

cc @hawkingrei @glorv

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 25, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 25, 2023
@hawkingrei hawkingrei requested a review from glorv June 25, 2023 06:41
@pingcap pingcap deleted a comment from tiprow bot Jun 25, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei requested a review from xhebox June 25, 2023 06:59
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-25 06:40:45.268551426 +0000 UTC m=+517010.669801878: ☑️ agreed by hawkingrei.
  • 2023-06-25 07:08:09.842638088 +0000 UTC m=+518655.243888536: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit b9d28a6 into pingcap:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable test TestResourceGroupRunaway
3 participants
@CabinfeverB @hawkingrei @xhebox