Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix correctness of the correlated predicate push down for cte (#43759) #44946

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43759

What problem does this PR solve?

Issue Number: close #43645

Problem Summary:

The predicate push-down might change the correlated status of the CTE. Our current implementation will cause the wrong result.

What is changed and how it works?

We disable that case's pushing down first.
I will support it later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that pushing the correlated filter into CTE might cause the wrong result.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 26, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2023
@YangKeao YangKeao force-pushed the cherry-pick-43759-to-release-6.1 branch from 2b75df1 to 4542f13 Compare June 29, 2023 13:36
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2023
@YangKeao
Copy link
Member

/retest

@YangKeao YangKeao changed the title planner: fix correctness of the correlated predicate push down for cte | tidb-test=pr/2128 (#43759) planner: fix correctness of the correlated predicate push down for cte (#43759) Jun 30, 2023
@YangKeao YangKeao changed the title planner: fix correctness of the correlated predicate push down for cte (#43759) planner: fix correctness of the correlated predicate push down for cte (#43759) Jun 30, 2023
winoros and others added 2 commits June 30, 2023 14:06
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the cherry-pick-43759-to-release-6.1 branch from 4542f13 to b7ace8d Compare June 30, 2023 06:06
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@YangKeao
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 06:40:21.276177067 +0000 UTC m=+67704.650754915: ☑️ agreed by YangKeao.
  • 2023-06-30 07:15:28.670622959 +0000 UTC m=+69812.045200811: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 9a3a7bf into pingcap:release-6.1 Jun 30, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants