-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix routes panic for csv data load (#45405) #45536
lightning: fix routes panic for csv data load (#45405) #45536
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45536 +/- ##
================================================
Coverage ? 74.4669%
================================================
Files ? 1083
Lines ? 352888
Branches ? 0
================================================
Hits ? 262785
Misses ? 73816
Partials ? 16287 |
/cc @lance6716 |
/cc @GMHDBJD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #45405
What problem does this PR solve?
Issue Number: close #43284
Problem Summary:
Routes does not work for standard csv data.
tidb/br/pkg/lightning/mydump/loader.go
Lines 512 to 527 in c0e7057
It does map initialization for
s.dbSchemas
, then operate ons.tableSchemas
,s.viewSchemas
, ands.tableDatas
. However, the scope ofs.tableSchemas
does not cover the latter three ones, resulting in accessing invalid memory address or nil pointer dereference.What is changed and how it works?
For
s.tableSchemas
,s.viewSchemas
, ands.tableDatas
, initialize for each of them respectively, instead of initializing fors.dbSchemas
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.