Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Don't set limit for GetRegionsInfoByRange function #45556

Merged
merged 1 commit into from
Jul 25, 2023
Merged

store: Don't set limit for GetRegionsInfoByRange function #45556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion store/helper/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@
// GetRegionsInfoByRange scans region by key range
func (h *Helper) GetRegionsInfoByRange(sk, ek []byte) (*RegionsInfo, error) {
var regionsInfo RegionsInfo
err := h.requestPD("GetRegionByRange", "GET", fmt.Sprintf("%v?key=%s&end_key=%s", pdapi.ScanRegions,
err := h.requestPD("GetRegionByRange", "GET", fmt.Sprintf("%v?key=%s&end_key=%s&limit=-1", pdapi.ScanRegions,

Check warning on line 811 in store/helper/helper.go

View check run for this annotation

Codecov / codecov/patch

store/helper/helper.go#L811 

Added line #L811 was not covered by tests
url.QueryEscape(string(sk)), url.QueryEscape(string(ek))), nil, &regionsInfo)
return &regionsInfo, err
}
Expand Down