Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: split ttl handler into new package #45569

Merged
merged 5 commits into from
Jul 26, 2023
Merged

server: split ttl handler into new package #45569

merged 5 commits into from
Jul 26, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #44940

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
server: split ttl handler
7acde6b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
37076f9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #45569 (ecdfeb6) into master (ef27b0e) will increase coverage by 0.0700%.
Report is 2 commits behind head on master.
The diff coverage is 71.1111%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45569        +/-   ##
================================================
+ Coverage   73.2413%   73.3114%   +0.0700%     
================================================
  Files          1266       1272         +6     
  Lines        389654     390973      +1319     
================================================
+ Hits         285388     286628      +1240     
- Misses        85981      86038        +57     
- Partials      18285      18307        +22
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3030% <71.1111%> (+0.0616%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0554% <ø> (-0.0110%) ⬇️
br 52.1093% <ø> (-0.0211%) ⬇️

@hawkingrei hawkingrei changed the title server: split ttl handler server: split ttl handler into new package Jul 26, 2023
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2023
YangKeao
YangKeao approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 02:36:59.803883055 +0000 UTC m=+321962.398414042: ☑️ agreed by lcwangchao.
  • 2023-07-26 02:56:46.041454469 +0000 UTC m=+323148.635985458: ☑️ agreed by YangKeao.

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
9441c40 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
7d63821 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
ecdfeb6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit eff4970 into pingcap:master Jul 26, 2023
@hawkingrei hawkingrei deleted the server branch July 26, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @lcwangchao @YangKeao