Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support no_hash_join hint on optimizer (#45538) #45654

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45538

What problem does this PR solve?

Issue Number: ref #45520

Problem Summary: planner: support no_hash_join hint on optimizer

What is changed and how it works?

planner: support no_hash_join hint on optimizer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added epic/hint release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Jul 28, 2023
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-45538-to-release-6.5 branch from 4802ff4 to 8cb5e66 Compare July 28, 2023 08:07
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 28, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 08:26:13.893501613 +0000 UTC m=+515716.488032604: ☑️ agreed by hawkingrei.
  • 2023-07-28 08:42:24.35276602 +0000 UTC m=+516686.947297009: ☑️ agreed by time-and-fate.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@230b5ff). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45654   +/-   ##
================================================
  Coverage               ?   73.6540%           
================================================
  Files                  ?       1081           
  Lines                  ?     346869           
  Branches               ?          0           
================================================
  Hits                   ?     255483           
  Misses                 ?      74961           
  Partials               ?      16425           

@ti-chi-bot ti-chi-bot bot merged commit e44839c into pingcap:release-6.5 Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. epic/hint lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants