-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disktask: replace failure nodes with alive ones #45935
Conversation
Skipping CI for Draft Pull Request. |
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45935 +/- ##
================================================
- Coverage 73.3303% 72.7226% -0.6078%
================================================
Files 1310 1331 +21
Lines 394940 401568 +6628
================================================
+ Hits 289611 292031 +2420
- Misses 86881 91048 +4167
- Partials 18448 18489 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
de725d4
to
5582076
Compare
/cc @GMHDBJD |
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: tangenta <tangenta@126.com>
/retest |
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary: This PR adds a simple mechanism to cancel existed subtask.
What is changed and how it works?
Dispatcher:
liveNodes
from etcd everyDefaultLiveNodesCheckTick
ticks inhandleRunning
.taskNodes
inhandleRunning
as a local cache.taskNodes
are absent fromliveNodes
, it is marked as failure. And random nodesliveNodes
will replace them. It is done byUpdateFailedSchedulerIDs
. The local cache is also updated.Scheduler:
Run(..)
for checking if the scheduler has been canceled by dispatcher. If so, callruntimeCancel
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.