Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45941

Closed
wants to merge 3 commits into from
Closed

lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45941

wants to merge 3 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45614

What problem does this PR solve?

Issue Number: close #45427

Problem Summary:

lightning wrongly use int64 to save NEXT_GLOBAL_ROW_ID.

pingcap/tiflow#9391 (comment)

What is changed and how it works?

https://github.com/pingcap/tidb/blob/f1b9da103166162944ae41dc0943c93c0b91923b/br/pkg/lightning/backend/tidb/tidb.go#L847C1-L852

nextID's type is changed to string.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 9, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Aug 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guo-shaoge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2023
@lyzx2001
Copy link
Contributor

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 August 15, 2023 14:05
@lyzx2001
Copy link
Contributor

/retest

2 similar comments
@lyzx2001
Copy link
Contributor

/retest

@lyzx2001
Copy link
Contributor

/retest

@lyzx2001
Copy link
Contributor

/test unit-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

@lyzx2001: No presubmit jobs available for pingcap/tidb@release-5.3

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tiprow
Copy link

tiprow bot commented Aug 16, 2023

@lyzx2001: No presubmit jobs available for pingcap/tidb@release-5.3

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/run-unit-test

1 similar comment
@lyzx2001
Copy link
Contributor

/run-unit-test

@lyzx2001
Copy link
Contributor

/cc @lance6716

lance6716
lance6716 reviewed Aug 16, 2023
View reviewed changes
br/pkg/lightning/restore/meta_manager.go Outdated
@@ -267,7 +267,7 @@ func (m *dbTableMetaMgr) AllocTableRowIDs(ctx context.Context, rawRowIDMax int64
found := false
for _, info := range autoIDInfos {
if strings.ToLower(info.Column) == autoIDField {
maxRowIDMax = info.NextID - 1
maxRowIDMax = int64(info.NextID) - 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be changed to uint64 rather than cast it to int64. otherwise we can't handle the large values like 10942694589135710585. But I think many old codes already assume the rowID type is int64 and I'm not sure we can change them 🤔 Will take a look later

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot closed this Dec 1, 2023
@ti-chi-bot
Copy link
Member Author

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

Assignees

@lyzx2001 lyzx2001

Labels
do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @lyzx2001 @lance6716