Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix owner change flaky test #46075

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Aug 14, 2023

What problem does this PR solve?

Issue Number: close #46014

Problem Summary:
Subtask in tests are not reentrant.

What is changed and how it works?

Use map instead of atomic.Int64

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2023
@tiprow
Copy link

tiprow bot commented Aug 14, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #46075 (73f21c0) into master (c34f6fc) will decrease coverage by 2.0570%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46075        +/-   ##
================================================
- Coverage   74.7608%   72.7038%   -2.0570%     
================================================
  Files          1293       1300         +7     
  Lines        398103     399891      +1788     
================================================
- Hits         297625     290736      -6889     
- Misses        81108      90707      +9599     
+ Partials      19370      18448       -922     
Flag Coverage Δ
integration 25.7527% <ø> (-20.5102%) ⬇️
unit 73.3759% <ø> (+0.0299%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0548% <ø> (-0.0109%) ⬇️
br 47.6243% <ø> (-16.9053%) ⬇️

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 03:47:54.432723834 +0000 UTC m=+602838.981739823: ☑️ agreed by GMHDBJD.
  • 2023-08-15 04:00:38.587567045 +0000 UTC m=+603603.136583018: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit dbf7602 into pingcap:master Aug 15, 2023
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test TestOwnerChange
3 participants