Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Fix RangeTree.GetIncompleteRange when the rangeTree is empty. (#37086) #46167

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #37086

Issue Number: #37085

Signed-off-by: pingyu yuping@pingcap.com

What problem does this PR solve?

Issue Number: close #37085

Problem Summary: RangeTree.GetIncompleteRange return wrong result when the rangeTree is empty

What is changed and how it works?

  1. Judge whether rangeTree is empty (by pivot can be found or not).
  2. Return the last range if pivot is not found.
  3. Also revert the work around to this issue introduced in #32614 for raw backup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix `RangeTree.GetIncompleteRange` when the `rangeTree` is empty.

Issue Number: pingcap#37085

Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 17, 2023
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 17, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-17 03:10:08.661573545 +0000 UTC m=+773373.210589529: ☑️ agreed by Leavrth.
  • 2023-08-17 04:10:00.150186504 +0000 UTC m=+776964.699202490: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@aecde7c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46167   +/-   ##
================================================
  Coverage               ?   73.6450%           
================================================
  Files                  ?       1083           
  Lines                  ?     347730           
  Branches               ?          0           
================================================
  Hits                   ?     256086           
  Misses                 ?      75191           
  Partials               ?      16453           

@ti-chi-bot ti-chi-bot bot merged commit d331b78 into pingcap:release-6.5 Aug 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants