-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/lightning : remove get_regions call in physical backend (#46202) #46336
pkg/lightning : remove get_regions call in physical backend (#46202) #46336
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46336 +/- ##
================================================
Coverage ? 73.7019%
================================================
Files ? 1086
Lines ? 349596
Branches ? 0
================================================
Hits ? 257659
Misses ? 75475
Partials ? 16462 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #46202
What problem does this PR solve?
Problem Summary:
When lightning runs in physical import mode, it runs this sql query
SELECT REGION_ID, APPROXIMATE_SIZE FROM information_schema.TIKV_REGION_STATUS WHERE TABLE_ID = ?
This call is made by each lightning process in parallel import mode and by multiple worker threads in a lightning process. It can potentially overload the PD if number of regions are too many. However, it appears that this call may be unnecessary since its purpose is to display a warning message and increment a counter in the SplitAndScatterRegionByRanges() function. Considering that lightning physical import always operates on a new table, splitting the new region should not pose any harm.
Issue Number: close #45507
What is changed and how it works?
Remove the getRegions call from lightning
Check List
Tests
Release note
We saw this issue in 6.5.0
Please refer to Release Notes Language Style Guide to write a quality release note.