disttask: record subtask start/update time #46361
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/check-issue-triage-complete |
|
/ok-to-test |
D3Hunter
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46361 +/- ##
================================================
- Coverage 73.3647% 72.7205% -0.6443%
================================================
Files 1288 1312 +24
Lines 393441 400671 +7230
================================================
+ Hits 288647 291370 +2723
- Misses 86427 90862 +4435
- Partials 18367 18439 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
|
@ywqzzy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| StartTime time.Time | ||
| // UpdateTime is the time when the subtask is updated. | ||
| // it can be used as subtask end time if the subtask is finished. | ||
| // it's 0 if it hasn't started yet. |
There was a problem hiding this comment.
Since updteTime is end time， when it is 0， then not means not start.
There was a problem hiding this comment.
Since updteTime is end time
it's not the end time, it can be used as subtask end time ONLY IF the subtask is finished.
There was a problem hiding this comment.
what I mean is “it's 0 if it hasn't started yet.” is not correct，will startsubtask update both starttime and updatetime during starttime？
| @@ -73,6 +73,7 @@ type Manager struct { | |||
| // cancelFunc is used to fast cancel the scheduler.Run. | |||
| handlingTasks map[int64]context.CancelFunc | |||
| } | |||
| // server id, it's host:port for now. | |||
There was a problem hiding this comment.
| // server id, it's host:port for now. | |
| // id, it's host:port for now. |
There was a problem hiding this comment.
Currently, the manager's id == scheduler's id == server id
There was a problem hiding this comment.
server id is will cause confuse, since the name of struct has explain what id for, let's delete server id.
There was a problem hiding this comment.
it means it same as server id, updated
| cancel context.CancelFunc | ||
| ctx context.Context | ||
| cancel context.CancelFunc | ||
| // server id, it's host:port for now. |
There was a problem hiding this comment.
| // server id, it's host:port for now. | |
| // id, it's host:port for now. |
|
/test tiprow_fast_test |
|
@D3Hunter: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/LGTM |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #45990
Problem Summary:
What is changed and how it works?
StartSubtask, and some refactorCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.