-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask: dynamic dispatch subtasks #46593
Conversation
Skipping CI for Draft Pull Request. |
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46593 +/- ##
================================================
- Coverage 73.3585% 72.4411% -0.9174%
================================================
Files 1327 1348 +21
Lines 396878 405685 +8807
================================================
+ Hits 291144 293883 +2739
- Misses 87170 93076 +5906
- Partials 18564 18726 +162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I will remove the EnableDynamicDispatch column |
/cc @wjhuang2016 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
@ywqzzy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary:
In previous implementation, we batch all subtasks in one txn to submit subtasks.
It's possible that all subtasks are big then the size will up to txn limit.
And generating all subtasks will be slow, which will make some tidb workers idle.
What is changed and how it works?
Generate and dispatch subtasks in multiple txns.
In DispatcherExt, add the following 2 intefaces:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.