statistics, planner: use the correct IndexInfo in GenerateHistCollFromColumnInfo() | tidb-test=pr/2211 (#44441)
#46728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
ti-chi-bot
bot
added
release-note-none
12 tasks
ti-chi-bot
bot
added
size/L
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
size/M
|
/retest |
1 similar comment
|
/retest |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
YangKeao
changed the title
IndexInfo in GenerateHistCollFromColumnInfo() | tidb-test=pr/2149 (#44441)IndexInfo in GenerateHistCollFromColumnInfo() | tidb-test=pr/2211 (#44441)
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46728 +/- ##
================================================
Coverage ? 73.7748%
================================================
Files ? 1085
Lines ? 349969
Branches ? 0
================================================
Hits ? 258189
Misses ? 75297
Partials ? 16483 |
hawkingrei
approved these changes
Sep 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
cherry-pick-approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44441
What problem does this PR solve?
Issue Number: close #44369
Problem Summary:
We saved the
IndexInfoin the stats cache, and use it in the query.But it may be outdated after DDL, which will cause some strange and unexpected result.
In this bug, we generated an incomplete
HistColl.Idx2ColumnIDs.The following estimation logic panicked when trying to get the needed column that was missing in it.
What is changed and how it works?
Use the
IndexInfofrom theDataSource.tableInfo.IndicesinGenerateHistCollFromColumnInfo.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.