Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Exchange partition, fix LIST COLUMNs validation as well as NULL validation (#46533) #46766

Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 7, 2023

This is an manual cherry-pick of #46533 and #45980

What problem does this PR solve?

Issue Number: close #46492

Problem Summary:
The main issue was that the values are store in single quoted strings, and when adding them to the parser as parameters, they are quoted again, which issues (ignored) internal warnings, and no matching rows will be found.

Also the check did not handle NULL, so I added proper null-safe comparison.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023
@YangKeao YangKeao requested a review from mjonss September 7, 2023 16:15
@YangKeao
Copy link
Member Author

YangKeao commented Sep 7, 2023

/retest

2 similar comments
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2023

/retest

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2023

/retest

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2023

/retest

xhebox
xhebox previously approved these changes Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 8, 2023
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2023

/retest

tiancaiamao
tiancaiamao previously approved these changes Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-08 05:59:41.506313101 +0000 UTC m=+2684346.055329085: ☑️ agreed by xhebox.
  • 2023-09-08 17:02:25.180898547 +0000 UTC m=+29527.105454941: ☑️ agreed by tiancaiamao.

@hawkingrei
Copy link
Member

/test all

@tiprow
Copy link

tiprow bot commented Sep 10, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-6.5-20230907-v6.5.3

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangKeao
Copy link
Member Author

This PR is blocked by #45980

@YangKeao YangKeao dismissed stale reviews from tiancaiamao and xhebox via 290de29 September 12, 2023 03:11
@YangKeao YangKeao requested a review from a team as a code owner September 12, 2023 03:11
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
close pingcap#45791, close pingcap#45920

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230907-v6.5.3@71e6696). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20230907-v6.5.3     #46766   +/-   ##
================================================================
  Coverage                               ?   73.4513%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346488           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254500           
  Misses                                 ?      75577           
  Partials                               ?      16411           

@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8381ca7 into pingcap:release-6.5-20230907-v6.5.3 Sep 12, 2023
6 checks passed
YangKeao added a commit to YangKeao/tidb that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants