-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Exchange partition, fix LIST COLUMNs validation as well as NULL validation (#46533) #46766
*: Exchange partition, fix LIST COLUMNs validation as well as NULL validation (#46533) #46766
Conversation
/retest |
2 similar comments
/retest |
/retest |
/retest |
/retest |
[LGTM Timeline notifier]Timeline:
|
/test all |
@hawkingrei: No presubmit jobs available for pingcap/tidb@release-6.5-20230907-v6.5.3 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is blocked by #45980 |
290de29
to
ff248b9
Compare
close pingcap#45791, close pingcap#45920 Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ff248b9
to
b3bbd5d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20230907-v6.5.3 #46766 +/- ##
================================================================
Coverage ? 73.4513%
================================================================
Files ? 1080
Lines ? 346488
Branches ? 0
================================================================
Hits ? 254500
Misses ? 75577
Partials ? 16411 |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8381ca7
into
pingcap:release-6.5-20230907-v6.5.3
This is an manual cherry-pick of #46533 and #45980
What problem does this PR solve?
Issue Number: close #46492
Problem Summary:
The main issue was that the values are store in single quoted strings, and when adding them to the parser as parameters, they are quoted again, which issues (ignored) internal warnings, and no matching rows will be found.
Also the check did not handle NULL, so I added proper null-safe comparison.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.