-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: relax the check in ownerCheckAllVersions (#46752) #46793
ddl: relax the check in ownerCheckAllVersions (#46752) #46793
Conversation
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Benjamin2037 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #46752
What problem does this PR solve?
Issue Number: close #46751
Problem Summary:
If etcd is not clean successfully, and the tidb is down.
The owner can see an older version with the down tidb-id in ownerCheckAllVersions.
What is changed and how it works?
Check if the tidb-id exists in the cluster.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
Insert code Sleep before owner cleaning etcd mdl info, and kill the tidb when sleeping.
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.