Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: cherrypick some PRs to fix MDL bug #47079

Merged

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Sep 19, 2023

cherry-pick #46921 and #46752

What problem does this PR solve?

Issue Number: close #46920

Problem Summary:

What is changed and how it works?

  1. Check once for every DDL job.
  2. Check if waitSchemaChange is returned correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230625-v6.5.3@5d19713). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20230625-v6.5.3     #47079   +/-   ##
================================================================
  Coverage                               ?   73.4095%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346448           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254326           
  Misses                                 ?      75694           
  Partials                               ?      16428           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 19, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-19 16:06:22.718075886 +0000 UTC m=+619948.685663938: ☑️ agreed by tangenta.
  • 2023-09-20 06:32:12.675430783 +0000 UTC m=+671898.643018833: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit ecc2f3e into pingcap:release-6.5-20230625-v6.5.3 Sep 20, 2023
3 checks passed
wjhuang2016 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants