Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: add cleanup routine for framework #47218

Merged
merged 24 commits into from
Sep 25, 2023
Merged

disttask: add cleanup routine for framework #47218

merged 24 commits into from
Sep 25, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

What is changed and how it works?

add cleanUpLoop to call cleanUpRoutine to each type of tasks.
We cleanUp routine done, transfer finished tasks to history table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ywqzzy ywqzzy requested a review from a team as a code owner September 25, 2023 00:48
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

Hi @ywqzzy. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Sep 25, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/label ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 25, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ti-chi-bot ti-chi-bot bot removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #47218 (4bc25e5) into master (dd70123) will decrease coverage by 0.2714%.
Report is 5 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47218        +/-   ##
================================================
- Coverage   72.9209%   72.6495%   -0.2714%     
================================================
  Files          1340       1363        +23     
  Lines        400295     407500      +7205     
================================================
+ Hits         291899     296047      +4148     
- Misses        89463      92605      +3142     
+ Partials      18933      18848        -85
Flag Coverage Δ
integration 33.3951% <10.5932%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9340% <ø> (ø)
br 48.7111% <ø> (-4.3642%) ⬇️

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

GMHDBJD
GMHDBJD approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 08:06:40.091934165 +0000 UTC m=+262189.810276382: ☑️ agreed by D3Hunter.
  • 2023-09-25 09:06:41.335008976 +0000 UTC m=+265791.053351193: ☑️ agreed by GMHDBJD.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

1 similar comment
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy ywqzzy mentioned this pull request Sep 25, 2023
Closed
76 tasks
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/retest

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 25, 2023

/test all

@ti-chi-bot ti-chi-bot bot merged commit dc8eade into pingcap:master Sep 25, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ywqzzy @D3Hunter @GMHDBJD