Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: move StatsUsage and TableDelta into new package #47238

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 25, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 25, 2023
@hawkingrei hawkingrei changed the title statistics: remove StatsUsage and TableDelta into new package statistics: move StatsUsage and TableDelta into new package Sep 25, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #47238 (403134c) into master (df76319) will decrease coverage by 0.2893%.
Report is 12 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47238        +/-   ##
================================================
- Coverage   72.9671%   72.6778%   -0.2893%     
================================================
  Files          1340       1363        +23     
  Lines        400269     406689      +6420     
================================================
+ Hits         292065     295573      +3508     
- Misses        89270      92299      +3029     
+ Partials      18934      18817       -117     
Flag Coverage Δ
integration 33.3727% <13.7931%> (?)
unit 72.9168% <100.0000%> (-0.0503%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9340% <ø> (-0.0036%) ⬇️
br 48.7531% <ø> (-4.3276%) ⬇️

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2023

/retest-required

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 07:46:48.826873631 +0000 UTC m=+260998.545215848: ☑️ agreed by qw4990.
  • 2023-09-25 13:03:10.589333142 +0000 UTC m=+279980.307675368: ☑️ agreed by hi-rustin.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 48f6b35 into pingcap:master Sep 25, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants