Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: handle left subtask in running state #47300

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Sep 26, 2023

What problem does this PR solve?

Issue Number: close #46735

Problem Summary:

What is changed and how it works?

handle left subtask in running state depends on whether the subtask is idempotent, if true we rerun it, else we fail it.

all import-subtask is idempotent. add-index is left as true too, but require additional pr to make real true.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2023
@tiprow
Copy link

tiprow bot commented Sep 26, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment on lines 164 to 165
// TODO: implement this later.
return false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D3Hunter
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #47300 (a248793) into master (be3c939) will decrease coverage by 0.3206%.
Report is 4 commits behind head on master.
The diff coverage is 79.2452%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47300        +/-   ##
================================================
- Coverage   72.9197%   72.5992%   -0.3206%     
================================================
  Files          1347       1351         +4     
  Lines        401053     401773       +720     
================================================
- Hits         292447     291684       -763     
- Misses        89636      90967      +1331     
- Partials      18970      19122       +152     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 72.5898% <79.2452%> (-0.3300%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.8981% <ø> (-0.0252%) ⬇️
br 53.0633% <ø> (-0.0160%) ⬇️

@D3Hunter
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 26, 2023
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-26 13:04:01.779522793 +0000 UTC m=+366431.497865011: ☑️ agreed by tangenta.
  • 2023-09-26 13:07:00.456240503 +0000 UTC m=+366610.174582705: ☑️ agreed by Benjamin2037.

@D3Hunter
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 56a1af7 into pingcap:master Sep 26, 2023
@D3Hunter D3Hunter deleted the scheduler-ha branch September 26, 2023 14:42
@D3Hunter
Copy link
Contributor Author

/cherry-pick release-7.4

@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch release-7.4: #47304.

In response to this:

/cherry-pick release-7.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import into jobs is always running after kill ddl owner
4 participants