-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask: handle left subtask in running state #47300
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ddl/backfilling_dist_scheduler.go
Outdated
// TODO: implement this later. | ||
return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benjamin2037 @tangenta ptal
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47300 +/- ##
================================================
- Coverage 72.9197% 72.5992% -0.3206%
================================================
Files 1347 1351 +4
Lines 401053 401773 +720
================================================
- Hits 292447 291684 -763
- Misses 89636 90967 +1331
- Partials 18970 19122 +152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This reverts commit 2719303.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/cherry-pick release-7.4 |
@D3Hunter: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #46735
Problem Summary:
What is changed and how it works?
handle left subtask in running state depends on whether the subtask is idempotent, if true we rerun it, else we fail it.
all import-subtask is idempotent. add-index is left as true too, but require additional pr to make real true.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.