Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move some common code on stats to stats_util #47312

Merged
merged 8 commits into from
Sep 27, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 27, 2023

What problem does this PR solve?

Issue Number: ref #46905

Problem Summary: planner: move some common code on stats to stats_util

What is changed and how it works?

planner: move some common code on stats to stats_util

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2023
@tiprow
Copy link

tiprow bot commented Sep 27, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 27, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 03:49:03.439638793 +0000 UTC m=+419533.157981010: ☑️ agreed by hawkingrei.
  • 2023-09-27 03:54:08.761626084 +0000 UTC m=+419838.479968302: ☑️ agreed by time-and-fate.

@tiprow
Copy link

tiprow bot commented Sep 27, 2023

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test e328fc6 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #47312 (2fe1315) into master (99d9d41) will increase coverage by 0.1215%.
Report is 1 commits behind head on master.
The diff coverage is 83.5164%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47312        +/-   ##
================================================
+ Coverage   72.5647%   72.6862%   +0.1215%     
================================================
  Files          1348       1370        +22     
  Lines        401100     407392      +6292     
================================================
+ Hits         291057     296118      +5061     
- Misses        90941      92447      +1506     
+ Partials      19102      18827       -275     
Flag Coverage Δ
integration 36.7033% <43.9560%> (?)
unit 72.4768% <79.1208%> (-0.0879%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.8622% <ø> (-0.0108%) ⬇️
br 48.7367% <ø> (-4.2968%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0cc2f5c into pingcap:master Sep 27, 2023
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants