-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: Update global count and modify_count only if partition is not locked #47319
Conversation
Hi @hi-rustin. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47319 +/- ##
================================================
+ Coverage 72.3510% 72.7718% +0.4207%
================================================
Files 1352 1373 +21
Lines 400815 407406 +6591
================================================
+ Hits 289994 296477 +6483
- Misses 91660 92172 +512
+ Partials 19161 18757 -404
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0169567
to
547dff6
Compare
/retest |
@hi-rustin: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
/retest |
@hi-rustin: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
… not locked statistics: fix order statistics: add more tests statistics: fix test statistics: fix test statistics: add more tests statistics: better code statistics: fix wrong condition statistics: update comment
e852581
to
6add9a6
Compare
[LGTM Timeline notifier]Timeline:
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, time-and-fate, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #46351
close #47335
Problem Summary:
What is changed and how it works?
unlock stats t
to unlock the partition.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.