Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: export method for needChangeColumns #47492

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Oct 9, 2023

What problem does this PR solve?

Issue Number: ref #46258 pingcap/tiflow#9850

Problem Summary:

What is changed and how it works?

export method for dm to judge ddl type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 9, 2023
@tiprow
Copy link

tiprow bot commented Oct 9, 2023

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #47492 (adb7b1d) into master (1f5179a) will increase coverage by 0.6617%.
Report is 8 commits behind head on master.
The diff coverage is 83.7837%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47492        +/-   ##
================================================
+ Coverage   72.0917%   72.7534%   +0.6617%     
================================================
  Files          1353       1376        +23     
  Lines        401214     409201      +7987     
================================================
+ Hits         289242     297708      +8466     
+ Misses        92700      92640        -60     
+ Partials      19272      18853       -419     
Flag Coverage Δ
integration 39.6926% <59.4594%> (?)
unit 72.2029% <83.7837%> (+0.1112%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.6681% <ø> (ø)
br 48.9150% <ø> (-4.2883%) ⬇️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 10, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 10, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 10, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-10 07:19:37.383113565 +0000 UTC m=+1123174.970223708: ☑️ agreed by tangenta.
  • 2023-10-10 07:38:28.472058028 +0000 UTC m=+1124306.059168173: ☑️ agreed by okJiang.

@okJiang
Copy link
Member

okJiang commented Oct 10, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 10, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Oct 10, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 379ea38 into pingcap:master Oct 10, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants