-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distask: fix panic on refresh task fails or returns nil #47525
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47525 +/- ##
================================================
+ Coverage 72.1648% 72.7702% +0.6053%
================================================
Files 1354 1375 +21
Lines 401299 407650 +6351
================================================
+ Hits 289597 296648 +7051
+ Misses 92402 92176 -226
+ Partials 19300 18826 -474
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #47520
Problem Summary:
What is changed and how it works?
fix panic on refresh task fails or returns nil which makes dispatcher.Task nil
move delRunningTask of manager into defer
Check List
Tests
return
nil, nil
,nil, err
,task, nil
on GetGlobalTaskByID, check dispatcher.Task is always not nil, and updated correctly.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.