Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: define TaskType/TaskState/Step instead of string/int64 #47611

Merged
merged 13 commits into from
Oct 16, 2023
Merged

disttask: define TaskType/TaskState/Step instead of string/int64 #47611

merged 13 commits into from
Oct 16, 2023

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Oct 13, 2023

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2023
@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #47611 (669890b) into master (306be73) will increase coverage by 0.9358%.
Report is 2 commits behind head on master.
The diff coverage is 80.7692%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47611        +/-   ##
================================================
+ Coverage   71.9422%   72.8781%   +0.9358%     
================================================
  Files          1397       1420        +23     
  Lines        404701     411856      +7155     
================================================
+ Hits         291151     300153      +9002     
+ Misses        93938      92875      -1063     
+ Partials      19612      18828       -784
Flag Coverage Δ
integration 41.1986% <14.2857%> (?)
unit 71.9913% <87.5000%> (+0.0491%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6129% <ø> (-4.3469%) ⬇️

GMHDBJD
GMHDBJD approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-13 06:39:27.390711733 +0000 UTC m=+1379964.977821878: ☑️ agreed by tangenta.
  • 2023-10-13 08:08:49.416950363 +0000 UTC m=+1385327.004060508: ☑️ agreed by GMHDBJD.

@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

2 similar comments
@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@bb7133
Copy link
Member

bb7133 commented Oct 13, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@okJiang
Copy link
Member Author

okJiang commented Oct 13, 2023

/retest

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/test tiprow_fast_test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-ddl-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-mysql-client-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bb7133
Copy link
Member

bb7133 commented Oct 13, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented Oct 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit b3dcf59 into pingcap:master Oct 16, 2023
14 of 16 checks passed
@okJiang okJiang deleted the okJiang/first-ddl branch October 16, 2023 06:21
@ywqzzy ywqzzy mentioned this pull request Oct 16, 2023
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@okJiang @bb7133 @hawkingrei @tangenta @GMHDBJD