-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask: add sleep when subtask == nil #47668
Conversation
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47668 +/- ##
================================================
+ Coverage 71.9282% 72.8428% +0.9146%
================================================
Files 1396 1419 +23
Lines 404781 411152 +6371
================================================
+ Hits 291152 299495 +8343
+ Misses 94027 92826 -1201
+ Partials 19602 18831 -771
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary:
What is changed and how it works?
When subtask == nil but task is running, sleep for a while.
Very likely to happen when some tidb node is the tail, and some tidb node already processed all subtasks.
Check List
Tests
The cop request qps is really high.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.