Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain/metrics: add a metric for lease expired time #47730

Merged
merged 5 commits into from
Oct 18, 2023
Merged

domain/metrics: add a metric for lease expired time #47730

merged 5 commits into from
Oct 18, 2023

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Oct 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #47729

Problem Summary:
Add a metric for lease expired time.

What is changed and how it works?

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    tiup playground
    explore & edit & export ...
    import again & verify the changes ...
    image

  • No need to test

    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp
domain/metrics: add a metric for lease expired time
aed1d69 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp
update to microsecond
1d8be42 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp
milliseconds better
ead261e 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@jackysp jackysp added component/metrics and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@tiprow
Copy link

tiprow bot commented Oct 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jackysp
use seconds
bab3b96 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2023
@jackysp
update tidb.json
9429ca7 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@jackysp jackysp marked this pull request as ready for review October 17, 2023 22:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #47730 (9429ca7) into master (204d780) will increase coverage by 0.9018%.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47730        +/-   ##
================================================
+ Coverage   71.8868%   72.7887%   +0.9018%     
================================================
  Files          1397       1417        +20     
  Lines        405081     410789      +5708     
================================================
+ Hits         291200     299008      +7808     
+ Misses        94246      92977      -1269     
+ Partials      19635      18804       -831
Flag Coverage Δ
integration 41.2545% <100.0000%> (?)
unit 71.8981% <100.0000%> (+0.0113%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7131% <ø> (-4.2459%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 00:12:37.444285069 +0000 UTC m=+1788755.031395214: ☑️ agreed by hawkingrei.
  • 2023-10-18 02:13:01.58928002 +0000 UTC m=+1795979.176390165: ☑️ agreed by tangenta.

zimulala
zimulala approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tangenta,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0c9d228 into pingcap:master Oct 18, 2023
15 of 16 checks passed
jackysp added a commit to jackysp/tidb that referenced this pull request Oct 19, 2023
@jackysp
domain/metrics: add a metric for lease expired time (pingcap#47730)
d80bd20 
close pingcap#47729
cfzjywxk pushed a commit that referenced this pull request Nov 7, 2023
@jackysp
domain/metrics: add a metric for lease expired time (#47730) (#47819)
74df4d9 
close #47729
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @jackysp
domain/metrics: add a metric for lease expired time (pingcap#47730) (p…
81c377a 
…ingcap#47819) (pingcap#22)

close pingcap#47729

Co-authored-by: Jack Yu <jackysp@gmail.com>
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
@jackysp @wuhuizuo
domain/metrics: add a metric for lease expired time (pingcap#47730)
8df6a55 
close pingcap#47729
@Tema
Copy link
Contributor

Tema commented Apr 27, 2024

@jackysp could you please cherry-pick it into release-7.5?

@jackysp jackysp added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 27, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52932.

@jackysp
Copy link
Member Author

jackysp commented Apr 27, 2024

Sure! @Tema

ti-chi-bot bot pushed a commit that referenced this pull request May 6, 2024
@ti-chi-bot
domain/metrics: add a metric for lease expired time (#47730) (#52932)
dbd8ea2 
close #47729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@zimulala zimulala zimulala approved these changes

@tangenta tangenta tangenta approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
approved component/metrics lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a metric for lease expired time
6 participants
@jackysp @hawkingrei @Tema @ti-chi-bot @zimulala @tangenta