Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add integration test for pitr (#47740) #47907

Merged
merged 5 commits into from
Oct 31, 2023
Merged

br: add integration test for pitr (#47740) #47907

merged 5 commits into from
Oct 31, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47740

What problem does this PR solve?

Issue Number: ref #47738

Problem Summary:
add integration test for pitr

What is changed and how it works?

add integration test for pitr, currently only test for delete range

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#47740
c81b679 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 23, 2023
@Leavrth
resolve conflicts
9f94811 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@0540e51). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #47907   +/-   ##
================================================
  Coverage               ?   73.9561%           
================================================
  Files                  ?       1085           
  Lines                  ?     350935           
  Branches               ?          0           
================================================
  Hits                   ?     259538           
  Misses                 ?      74958           
  Partials               ?      16439

@Leavrth
fix integration test br_pitr
de8c105 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Oct 23, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 23, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 23, 2023

/run_br_integration_test

@Leavrth
Copy link
Contributor

Leavrth commented Oct 23, 2023

/run-br-integration-test

@Leavrth
compare the upstream delete range count
723ade9 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix unit test
e840d3b 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/run-integration-br-test

@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/run-br-integration-test

@purelind
Copy link
Contributor

/test ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 26, 2023

@purelind: The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@purelind: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 26, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Oct 27, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 27, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 06:04:57.146409056 +0000 UTC m=+2933094.733519186: ☑️ agreed by 3pointer.
  • 2023-10-31 06:05:41.446249418 +0000 UTC m=+2933139.033359564: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 31, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Oct 31, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 77e8bd9 into pingcap:release-6.5 Oct 31, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees

@Leavrth Leavrth

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @Leavrth @purelind @3pointer @YuJuncen