Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: fix s3 concurrent uploader will overwrite error (#48163) #48196

Merged
merged 4 commits into from
Nov 2, 2023
Merged

s3: fix s3 concurrent uploader will overwrite error (#48163) #48196

merged 4 commits into from
Nov 2, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48163

What problem does this PR solve?

Issue Number: close #48164

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 @ti-chi-bot
s3: fix s3 concurrent uploader will overwrite error
d3af167 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
refine comment
8f1b9ae 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
fix for ks3 as well
728510a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 @ti-chi-bot
add comment
9f1a21f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 1, 2023
@lance6716
Copy link
Contributor

/cc @D3Hunter

@ti-chi-bot ti-chi-bot bot requested a review from D3Hunter November 1, 2023 13:37
Benjamin2037
Benjamin2037 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-01 13:34:10.687487368 +0000 UTC m=+3046448.274597508: ☑️ agreed by lance6716.
  • 2023-11-02 02:15:38.35028486 +0000 UTC m=+3092135.937395005: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 2, 2023
@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 126b748 into pingcap:release-7.5 Nov 2, 2023
25 of 34 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-48163-to-release-7.5 branch November 2, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

Assignees

@lance6716 lance6716

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lance6716 @Benjamin2037 @Leavrth