-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: distinguish events of server level and connection level #48290
Conversation
Signed-off-by: Jack Yu <jackysp@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48290 +/- ##
================================================
+ Coverage 71.4917% 72.8022% +1.3105%
================================================
Files 1402 1425 +23
Lines 406373 412762 +6389
================================================
+ Hits 290523 300500 +9977
+ Misses 96016 93345 -2671
+ Partials 19834 18917 -917
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/ok-to-test |
What problem does this PR solve?
Issue Number: close #48289
Problem Summary:
What is changed and how it works?
Rename it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.