Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix typo in comment #48300

Merged
merged 2 commits into from
Nov 6, 2023
Merged

planner: fix typo in comment #48300

merged 2 commits into from
Nov 6, 2023

Conversation

shawn0915
Copy link
Contributor

@shawn0915 shawn0915 commented Nov 5, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary:
planner: fix typo in comment

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    • Only fix typo in comment.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

fix typo in comment.
fix typo in comment.
Copy link

ti-chi-bot bot commented Nov 5, 2023

Hi @shawn0915. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2023
Copy link

tiprow bot commented Nov 5, 2023

Hi @shawn0915. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shawn0915 shawn0915 changed the title planner, fix typo in comment planner: fix typo in comment Nov 5, 2023
@shawn0915
Copy link
Contributor Author

@zimulala PTAL

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 5, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 5, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #48300 (4b5615c) into master (4f00ece) will increase coverage by 1.3107%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48300        +/-   ##
================================================
+ Coverage   71.4917%   72.8024%   +1.3107%     
================================================
  Files          1402       1425        +23     
  Lines        406373     412762      +6389     
================================================
+ Hits         290523     300501      +9978     
+ Misses        96016      93345      -2671     
+ Partials      19834      18916       -918     
Flag Coverage Δ
integration 43.1737% <ø> (?)
unit 71.4779% <ø> (-0.0138%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6730% <ø> (-4.2626%) ⬇️

Copy link

ti-chi-bot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, ngaut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2023
Copy link

ti-chi-bot bot commented Nov 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-05 06:57:41.228878191 +0000 UTC m=+3368258.815988340: ☑️ agreed by hawkingrei.
  • 2023-11-06 01:38:35.46022438 +0000 UTC m=+3435513.047334525: ☑️ agreed by ngaut.

@ti-chi-bot ti-chi-bot bot merged commit 18979c6 into pingcap:master Nov 6, 2023
14 of 16 checks passed
@shawn0915 shawn0915 deleted the patch-1 branch November 6, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants