-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: refine info cache logic to reduce the impact of DDL on information schema cache (#48284) #48362
Merged
ti-chi-bot
merged 4 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-48284-to-release-7.5
Nov 7, 2023
Merged
infoschema: refine info cache logic to reduce the impact of DDL on information schema cache (#48284) #48362
ti-chi-bot
merged 4 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-48284-to-release-7.5
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
ti-chi-bot
added
ok-to-test
Indicates a PR is ready to be tested.
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Nov 7, 2023
Merged
13 tasks
crazycs520
approved these changes
Nov 7, 2023
lcwangchao
approved these changes
Nov 7, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Nov 7, 2023
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Nov 7, 2023
zimulala
approved these changes
Nov 7, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, lcwangchao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
ok-to-test
Indicates a PR is ready to be tested.
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48284
What problem does this PR solve?
Issue Number: ref: #48281 close #48285
Problem Summary: refine info cache logic to reduce the impact of DDL on information schema cache
What is changed and how it works?
Do same test in #48285, with this PR, the impact of
failed to get schema version
to stale read QPS is much smaller.The the related metric is following, as you can see, the QPS is much more stable and load snapshot ops is much lower.
Before This PR
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.