Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: more stable check liveness when store heartbeat behind too much #48403

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Nov 8, 2023

What problem does this PR solve?

Issue Number: close #48405

Problem Summary:
the storeheart could behind more than 100s if user set don't care the store heartbeat duration and set it to 1 minute.

What is changed and how it works?

  1. change 100s to 300s
  2. use more better retry mechanism.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked labels Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2023
Copy link

tiprow bot commented Nov 8, 2023

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer 3pointer marked this pull request as ready for review November 8, 2023 06:27
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #48403 (3b954d3) into master (57a1a9c) will increase coverage by 0.5183%.
Report is 327 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48403        +/-   ##
================================================
+ Coverage   71.3932%   71.9115%   +0.5183%     
================================================
  Files          1402       1466        +64     
  Lines        406865     459021     +52156     
================================================
+ Hits         290474     330089     +39615     
- Misses        96455     109598     +13143     
+ Partials      19936      19334       -602     
Flag Coverage Δ
integration 45.1745% <0.0000%> (?)
unit 71.3960% <ø> (+0.0028%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0463% <0.0000%> (-6.9919%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
Copy link

ti-chi-bot bot commented Dec 6, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
Copy link

ti-chi-bot bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 8, 2023
Copy link

ti-chi-bot bot commented Dec 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 05:29:40.314617526 +0000 UTC m=+1678208.979843720: ☑️ agreed by Leavrth.
  • 2023-12-08 07:33:24.780205391 +0000 UTC m=+1772033.445431608: ☑️ agreed by YuJuncen.

Copy link

tiprow bot commented Dec 8, 2023

@3pointer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 3b954d3 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Dec 14, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 7e5a5b2 into pingcap:master Dec 14, 2023
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup: wait more time to check store liveness
4 participants