-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: keep sort operator when ordered by tablesample (#48315) #48449
planner/core: keep sort operator when ordered by tablesample (#48315) #48449
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48449 +/- ##
================================================
Coverage ? 73.6569%
================================================
Files ? 1085
Lines ? 348934
Branches ? 0
================================================
Hits ? 257014
Misses ? 75445
Partials ? 16475 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #48315
What problem does this PR solve?
Issue Number: close #48253
Problem Summary:
TableSampleExecutor
does not process unsigned int handles. They are treated as the signed handles.What is changed and how it works?
Always keep the sort operator when a
TABLESAMPLE
query containsORDER BY
clause.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.