Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: fix copr cache panic when tidb_enable_collect_execution_info is off (#48340) #48476

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48340

What problem does this PR solve?

Issue Number: close #48212

Problem Summary:

Goroutine panic because of nil pointer dereference.

What is changed and how it works?

When coprocessor cache is hit, check the details before set execution info.

Because some internal tasks may lead to cache hit when tidb_enable_collect_execution_info is turned off, so this need to be checked.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
# shell1
tiup playground nightly --kv=3 --mode=tikv-slim
# shell2
export TIKV_PATH=127.0.0.1:2379
export TIDB_TEST_STORE_NAME=tikv
make integrationtest
  • Before

It may panic like the log in #48212

  • After

No panic

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 9, 2023
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 05:45:56.606438147 +0000 UTC m=+4055154.193548287: ☑️ agreed by Defined2014.
  • 2023-11-13 05:48:12.966150263 +0000 UTC m=+4055290.553260393: ☑️ agreed by wshwsh12.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@6927b21). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #48476   +/-   ##
================================================
  Coverage               ?   71.9834%           
================================================
  Files                  ?       1400           
  Lines                  ?     406603           
  Branches               ?          0           
================================================
  Hits                   ?     292687           
  Misses                 ?      94227           
  Partials               ?      19689           
Flag Coverage Δ
unit 71.9834% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2462% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 8a15fe4 into pingcap:release-7.5 Jan 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants