-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: fix copr cache panic when tidb_enable_collect_execution_info
is off (#48340)
#48476
copr: fix copr cache panic when tidb_enable_collect_execution_info
is off (#48340)
#48476
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: you06 <you1474600@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48476 +/- ##
================================================
Coverage ? 71.9834%
================================================
Files ? 1400
Lines ? 406603
Branches ? 0
================================================
Hits ? 292687
Misses ? 94227
Partials ? 19689
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #48340
What problem does this PR solve?
Issue Number: close #48212
Problem Summary:
Goroutine panic because of nil pointer dereference.
What is changed and how it works?
When coprocessor cache is hit, check the details before set execution info.
Because some internal tasks may lead to cache hit when
tidb_enable_collect_execution_info
is turned off, so this need to be checked.Check List
Tests
It may panic like the log in #48212
No panic
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.