ddl: we shouldn't make a DDL job to a dist task when it's on system DB in upgrading #48716
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48716 +/- ##
================================================
+ Coverage 71.0934% 72.7209% +1.6274%
================================================
Files 1364 1388 +24
Lines 404158 411070 +6912
================================================
+ Hits 287330 298934 +11604
+ Misses 96873 93246 -3627
+ Partials 19955 18890 -1065
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
needs-cherry-pick-release-7.5
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
pkg/ddl/index.go
Outdated
| } | ||
| if variable.EnableDistTask.Load() { | ||
| isDistReorg := false |
There was a problem hiding this comment.
Maybe useDistReorg is better to understand?
pkg/ddl/index.go
Outdated
| } else { | ||
| _, err = ingest.LitBackCtxMgr.Register(ctx, unique, job.ID, nil, pdLeaderAddr, job.ReorgMeta.ResourceGroupName) | ||
| if isUpgradingSysDB { | ||
| logutil.BgLogger().Info("pick backfill type, handle the job on the system DB in upgrading state", |
There was a problem hiding this comment.
The log is harder to understand. :(
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit-test |
|
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #48706
Problem Summary:
What is changed and how it works?
Check List
Tests
Ran IT as described in the issue
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.