-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: code preparations for supporting build range for like function on new collation columns | tidb-test=pr/2253 #48972
*: code preparations for supporting build range for like function on new collation columns | tidb-test=pr/2253 #48972
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48972 +/- ##
================================================
+ Coverage 70.9895% 72.2993% +1.3097%
================================================
Files 1368 1397 +29
Lines 403893 412691 +8798
================================================
+ Hits 286722 298373 +11651
+ Misses 97205 95497 -1708
+ Partials 19966 18821 -1145
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test mysql-test |
@time-and-fate: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@time-and-fate: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…new collation columns (pingcap#48972) ref pingcap#48181
…new collation columns (pingcap#48972) ref pingcap#48181
What problem does this PR solve?
Issue Number: ref #48181
What changed and how does it work?
like
to build range when new collation is enabled #48181, many values in ranges for string columns will become sort key (bytes) instead of the original value (usually string) like the previous. Because bytes and string have different printing formats when displaying the execution plan, this will make many changes in the displayed execution plan in the test cases. So I changed the formats of printing bytes to make it consistent with strings. (pkg/util/ranger/types.go
)like
to build range when new collation is enabled #48181, no matter what collation the column is, when it comes here, the datum might be the sort key, which must be bytes, and setting the datum to the collation of the column will be wrong. But this setting is needed, so we move it to an earlier stage. (pkg/executor/point_get.go
,pkg/planner/core/point_get_plan.go
)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.