-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gloabl sort: revert "writer upload data in background" #49118
Conversation
…ackground (pingcap#48873)" This reverts commit 720ae4b. Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49118 +/- ##
================================================
+ Coverage 71.0442% 72.0977% +1.0534%
================================================
Files 1368 1405 +37
Lines 402977 413361 +10384
================================================
+ Hits 286292 298024 +11732
+ Misses 96744 96524 -220
+ Partials 19941 18813 -1128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pingcap#48871)" This reverts commit 4309c0f.
…ll (pingcap#48871)" This reverts commit b35f796.
Signed-off-by: lance6716 <lance6716@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
revert #48873
This reverts commit 720ae4b.
What problem does this PR solve?
Issue Number: ref #49117 close #49111
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.