Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Enable plan cache for partitioned tables | tidb-test=pr/2273 #49161

Merged
merged 145 commits into from
Mar 12, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Dec 4, 2023

What problem does this PR solve?

Issue Number: close #33031 , close #45532

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@mjonss
Copy link
Contributor Author

mjonss commented Dec 4, 2023

/ok-to-test

Copy link

ti-chi-bot bot commented Dec 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a PR is ready to be tested. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2023
Copy link

tiprow bot commented Dec 4, 2023

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #49161 (f3c6807) into master (f2cbe00) will increase coverage by 2.0386%.
Report is 5 commits behind head on master.
The diff coverage is 85.6209%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49161        +/-   ##
================================================
+ Coverage   70.7299%   72.7686%   +2.0386%     
================================================
  Files          1473       1473                
  Lines        437058     437723       +665     
================================================
+ Hits         309131     318525      +9394     
+ Misses       108557      99162      -9395     
- Partials      19370      20036       +666     
Flag Coverage Δ
integration 48.8534% <74.3464%> (?)
unit 70.4803% <79.5751%> (-0.0559%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3097% <ø> (+5.4288%) ⬆️

@mjonss
Copy link
Contributor Author

mjonss commented Dec 4, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Dec 4, 2023

/retest

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Dec 4, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Dec 4, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Dec 5, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Dec 5, 2023

/retest

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Mar 8, 2024

/retest

return false
}

// Map each index value to Partition ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Map each index value to Partition index

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2024
Copy link

ti-chi-bot bot commented Mar 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-11 07:53:04.324420193 +0000 UTC m=+672011.346666582: ☑️ agreed by tiancaiamao.
  • 2024-03-11 08:19:56.052581633 +0000 UTC m=+673623.074828023: ☑️ agreed by qw4990.

@mjonss mjonss requested a review from tangenta March 11, 2024 12:26
Copy link

tiprow bot commented Mar 11, 2024

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 9fda2d9 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, tangenta, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
4 participants