-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix not-stable test about ExchangePartition when wait for ddl enter next state #49879
Conversation
Hi @jiyfhust. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49879 +/- ##
================================================
+ Coverage 70.9365% 70.9868% +0.0503%
================================================
Files 1368 1431 +63
Lines 396016 421737 +25721
================================================
+ Hits 280920 299378 +18458
- Misses 95433 103497 +8064
+ Partials 19663 18862 -801
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/auto-cc |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #49777
Problem Summary:
What changed and how does it work?
Same problem with #46815, the pr #46816 solve it by sleeping 50ms to wait domain load the new schemaVersion.
In most case it works, but it is only an
improvement
, it did not make it stable, the tests can also fails by some times.This pr solve it by check the new tableInfo, so it should be possible to handle it fundamentally.
This pr check the non-partition table
ExchangePartitionInfo
part, it will be not-null if it is in write-only state.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.