Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix not-stable test about ExchangePartition when wait for ddl enter next state #49879

Merged
merged 7 commits into from
Dec 29, 2023

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Dec 28, 2023

What problem does this PR solve?

Issue Number: close #49777

Problem Summary:

What changed and how does it work?

Same problem with #46815, the pr #46816 solve it by sleeping 50ms to wait domain load the new schemaVersion.
In most case it works, but it is only an improvement, it did not make it stable, the tests can also fails by some times.
This pr solve it by check the new tableInfo, so it should be possible to handle it fundamentally.

This pr check the non-partition table ExchangePartitionInfo part, it will be not-null if it is in write-only state.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2023
Copy link

tiprow bot commented Dec 28, 2023

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #49879 (c922e76) into master (60dbb61) will increase coverage by 0.0503%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49879        +/-   ##
================================================
+ Coverage   70.9365%   70.9868%   +0.0503%     
================================================
  Files          1368       1431        +63     
  Lines        396016     421737     +25721     
================================================
+ Hits         280920     299378     +18458     
- Misses        95433     103497      +8064     
+ Partials      19663      18862       -801     
Flag Coverage Δ
integration 43.9798% <ø> (?)
unit 70.9365% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9940% <ø> (-6.8844%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2023
@lance6716
Copy link
Contributor

/auto-cc

@lance6716
Copy link
Contributor

/cc @zimulala @mjonss

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 29, 2023
Copy link

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2023
Copy link

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-29 06:21:30.980484602 +0000 UTC m=+1805982.017711531: ☑️ agreed by Defined2014.
  • 2023-12-29 06:23:10.894152417 +0000 UTC m=+1806081.931379344: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit c575685 into pingcap:master Dec 29, 2023
18 checks passed
@jiyfhust jiyfhust deleted the fix_exchange_test branch December 29, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestExchangePartitionStates
4 participants