variable: fix information_schema.VARIABLES_INFO DEFAULT_VALUE not right problem (#49524)

[ti-chi-bot]

This is an automated cherry-pick of #49524

What problem does this PR solve?

Issue Number: close #49461, close #49968, close #50155

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Without this pr, deploy a cluster:

mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where DEFAULT_VALUE != CURRENT_VALUE and variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
+-----------------------------------+----------------+---------------+---------------+
| VARIABLE_NAME                     | VARIABLE_SCOPE | DEFAULT_VALUE | CURRENT_VALUE |
+-----------------------------------+----------------+---------------+---------------+
| tidb_row_format_version           | SESSION,GLOBAL | 1             | 2             |
| tidb_pessimistic_txn_fair_locking | SESSION,GLOBAL | OFF           | ON            |
| tidb_enable_async_commit          | SESSION,GLOBAL | OFF           | ON            |
| tidb_enable_mutation_checker      | SESSION,GLOBAL | OFF           | ON            |
| tidb_txn_mode                     | SESSION,GLOBAL |               | pessimistic   |
| tidb_txn_assertion_level          | SESSION,GLOBAL | OFF           | FAST          |
| tidb_enable_1pc                   | SESSION,GLOBAL | OFF           | ON            |
+-----------------------------------+----------------+---------------+---------------+
7 rows in set (0.07 sec)

With this pr:

mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where DEFAULT_VALUE != CURRENT_VALUE and variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
Empty set (0.01 sec)


mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
+-----------------------------------+----------------+---------------+---------------+
| VARIABLE_NAME                     | VARIABLE_SCOPE | DEFAULT_VALUE | CURRENT_VALUE |
+-----------------------------------+----------------+---------------+---------------+
| tidb_mem_oom_action               | GLOBAL         | CANCEL        | CANCEL        |
| tidb_enable_1pc                   | SESSION,GLOBAL | ON            | ON            |
| tidb_enable_async_commit          | SESSION,GLOBAL | ON            | ON            |
| tidb_enable_auto_analyze          | GLOBAL         | ON            | ON            |
| tidb_row_format_version           | SESSION,GLOBAL | 2             | 2             |
| tidb_txn_mode                     | SESSION,GLOBAL | pessimistic   | pessimistic   |
| tidb_pessimistic_txn_fair_locking | SESSION,GLOBAL | ON            | ON            |
| tidb_txn_assertion_level          | SESSION,GLOBAL | FAST          | FAST          |
| tidb_enable_mutation_checker      | SESSION,GLOBAL | ON            | ON            |
+-----------------------------------+----------------+---------------+---------------+
9 rows in set (0.01 sec)

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the behavior to show the right default value for some variables

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[YangKeao]

I don't know why it's closed previously. Re-open it now.

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/unit-test	8bd7b23	link	true	/test unit-test
idc-jenkins-ci-tidb/check_dev	8bd7b23	link	true	/test check-dev
idc-jenkins-ci-tidb/mysql-test	8bd7b23	link	true	/test mysql-test
idc-jenkins-ci-tidb/check_dev_2	8bd7b23	link	true	/test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-06 05:23:29.252678222 +0000 UTC m=+1018522.091833769: ☑️ agreed by xhebox.