-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: remove evict slow store scheduler #50776
br: remove evict slow store scheduler #50776
Conversation
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50776 +/- ##
================================================
+ Coverage 70.4854% 72.7436% +2.2582%
================================================
Files 1463 1463
Lines 433206 434570 +1364
================================================
+ Hits 305347 316122 +10775
+ Misses 108609 98494 -10115
- Partials 19250 19954 +704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -95,6 +95,8 @@ var ( | |||
"shuffle-leader-scheduler": {}, | |||
"shuffle-region-scheduler": {}, | |||
"shuffle-hot-region-scheduler": {}, | |||
|
|||
"evict-slow-store-scheduler": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but what if PD add new scheduler in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PD hasn't the list of all the scheduler.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #50566
Problem Summary:
one tikv has no leader and slow down br restore spee
What changed and how does it work?
remove
evict-slow-store-scheduler
when restoreCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.