-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add fmt lint setting for interface{}
#50825
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Hi @CabinfeverB. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
[LGTM Timeline notifier]Timeline:
|
@@ -13,7 +13,6 @@ | |||
// limitations under the License. | |||
|
|||
//go:build boringcrypto | |||
// +build boringcrypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50825 +/- ##
================================================
+ Coverage 70.4718% 72.0281% +1.5563%
================================================
Files 1466 1466
Lines 433806 433826 +20
================================================
+ Hits 305711 312477 +6766
+ Misses 108823 101583 -7240
- Partials 19272 19766 +494
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
/retest |
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
a7ce8e5
to
8478a9a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716, tiancaiamao, XuHuaiyu, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @hawkingrei |
/test build |
@CabinfeverB: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8478a9a
to
4b60354
Compare
What problem does this PR solve?
Issue Number: ref #50765
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.