Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: multi download and parse metafile #50829

Merged

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 30, 2024

What problem does this PR solve?

Issue Number: close #50772

Problem Summary:
br restore is very slow when there are many metafiles

What changed and how does it work?

multi download and parse metafile

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

1 hours -> 20 minutes

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2024
Copy link

tiprow bot commented Jan 30, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #50829 (e5f9ddd) into master (789cd3e) will increase coverage by 4.4438%.
Report is 246 commits behind head on master.
The diff coverage is 66.1538%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50829        +/-   ##
================================================
+ Coverage   72.2373%   76.6812%   +4.4438%     
================================================
  Files          1465       1481        +16     
  Lines        360787     475154    +114367     
================================================
+ Hits         260623     364354    +103731     
- Misses        80896      90755      +9859     
- Partials      19268      20045       +777     
Flag Coverage Δ
integration 51.2580% <61.5384%> (?)
unit 73.6020% <65.3846%> (+1.4832%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1396% <ø> (-2.3375%) ⬇️
parser ∅ <ø> (∅)
br 58.3008% <66.1538%> (+12.0585%) ⬆️

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
…h/tidb into multi_download_and_parse_metafile
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2024
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if err != nil {
return errors.Trace(err)
}
decryptContent, err := Decrypt(content, cipher, node.CipherIv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a copy of cipher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a readonly data.

@Leavrth
Copy link
Contributor Author

Leavrth commented Feb 28, 2024

/retest

Copy link

tiprow bot commented Feb 28, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Mar 5, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 5, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
Copy link

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-04 09:44:44.641285077 +0000 UTC m=+73911.663531467: ☑️ agreed by 3pointer.
  • 2024-03-06 03:17:11.286526245 +0000 UTC m=+223458.308772628: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit ad28e23 into pingcap:master Mar 6, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br restore is very slow when there are many metafiles
3 participants