-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: introduce MutateContext
and AllocatorContext
for table.Table
#50862
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50862 +/- ##
================================================
+ Coverage 70.5059% 72.6196% +2.1137%
================================================
Files 1465 1467 +2
Lines 433728 434312 +584
================================================
+ Hits 305804 315396 +9592
+ Misses 108673 99049 -9624
- Partials 19251 19867 +616
Flags with carried forward coverage won't be shown. Click here to find out more.
|
474ca07
to
601a996
Compare
601a996
to
ca2187e
Compare
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #50861
Problem Summary:
It's better to introduce standalone context definitions for methods in
table.Table
to decouple it from sessionWhat changed and how does it work?
Provide two standalone context definitions:
table.MutateContext
is used byAddRecord
/UpdateRecord
/RemoveRecord
table.AllocatorContext
is used bytable.Allocators
to provide context for allocate id for temporary tables.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.