-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: auto tune concurrency configuration when using new mode restoration #50877
Conversation
Skipping CI for Draft Pull Request. |
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50877 +/- ##
=================================================
- Coverage 70.3605% 58.0036% -12.3570%
=================================================
Files 1456 1581 +125
Lines 420835 619732 +198897
=================================================
+ Hits 296102 359467 +63365
- Misses 104393 236833 +132440
- Partials 20340 23432 +3092
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
return c.Import.Threads, nil | ||
} | ||
|
||
func ParseMergeRegionSizeFromConfig(resp []byte) (uint64, uint64, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this function is only called in conn
package and doesn't rely on any item in config
. Why not make it a private function in conn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to put all parse config logic into one pkg for future usage.
@@ -7,6 +7,7 @@ import ( | |||
|
|||
"github.com/pingcap/errors" | |||
"github.com/pingcap/log" | |||
kvconfig "github.com/pingcap/tidb/br/pkg/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename it to kvconfig
? It seems belongs to BR. Perhaps use pconfig
as restore.go
did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all logic belong to TiKV could use this name
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@3pointer: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #50701
Problem Summary:
make concurrency easy to use for user.
What changed and how does it work?
based on tikv config
import.num-threads
to determine the concurrency.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.