Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove direct dependencies with sessionctx.Context for package expression #51025

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #51024

What changed and how does it work?

In this PR, we removed all direct dependencies with sessionctx.Context for package expression to make sure the argument of function is BuildContext or EvalContext

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2024
Copy link

tiprow bot commented Feb 7, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #51025 (55ef3f8) into master (526d738) will increase coverage by 2.0669%.
Report is 14 commits behind head on master.
The diff coverage is 93.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51025        +/-   ##
================================================
+ Coverage   70.5459%   72.6129%   +2.0669%     
================================================
  Files          1467       1467                
  Lines        434878     436652      +1774     
================================================
+ Hits         306789     317066     +10277     
+ Misses       108811      99672      -9139     
- Partials      19278      19914       +636     
Flag Coverage Δ
integration 49.1990% <88.0000%> (?)
unit 70.3098% <93.3333%> (-0.0461%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (-0.1820%) ⬇️
parser ∅ <ø> (∅)
br 51.1276% <ø> (+5.3797%) ⬆️

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 06:19:46.72535862 +0000 UTC m=+337712.292128494: ☑️ agreed by YangKeao.
  • 2024-02-07 07:13:31.829398415 +0000 UTC m=+340937.396168306: ☑️ agreed by hawkingrei.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonn7
Copy link

easonn7 commented Feb 8, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, windtalker, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit c5eced1 into pingcap:master Feb 8, 2024
21 checks passed
@lcwangchao lcwangchao deleted the expression_full_ctx branch February 8, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove direct dependency with sessionctx.Context of package expression
5 participants