Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: dont check runaway after resp #51160

Merged

Conversation

CabinfeverB
Copy link
Contributor

@CabinfeverB CabinfeverB commented Feb 19, 2024

What problem does this PR solve?

Issue Number: close #51161

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2024
Copy link

tiprow bot commented Feb 19, 2024

Hi @CabinfeverB. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #51160 (ae03f2e) into master (fa340f3) will decrease coverage by 15.8038%.
Report is 6 commits behind head on master.
The diff coverage is 87.5000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51160         +/-   ##
=================================================
- Coverage   70.5856%   54.7819%   -15.8038%     
=================================================
  Files          1467       1576        +109     
  Lines        434785     603212     +168427     
=================================================
+ Hits         306896     330451      +23555     
- Misses       108621     249750     +141129     
- Partials      19268      23011       +3743     
Flag Coverage Δ
integration 37.0741% <0.0000%> (?)
unit 70.3879% <87.5000%> (+0.0054%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3197% <ø> (+5.4640%) ⬆️

@CabinfeverB
Copy link
Contributor Author

cc @nolouch

@CabinfeverB
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Feb 19, 2024

@CabinfeverB: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

address comment

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB CabinfeverB force-pushed the resource_manager/runaway_after_check branch from af9aa9d to ae03f2e Compare February 20, 2024 08:05
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 09:59:29.355513183 +0000 UTC m=+264858.103136278: ☑️ agreed by glorv.
  • 2024-02-20 08:09:35.629364902 +0000 UTC m=+344664.376988009: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 80fd960 into pingcap:master Feb 20, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After setting runaway, got an unexpected error Coprocessor task terminated due to exceeding the deadline
5 participants