Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix CTE goroutine leak when exceeds mem quota (#50828) #51166

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50828

What problem does this PR solve?

Issue Number: close #50337

Problem Summary:

  1. when child.Close() return error, there may leaking resource.
  2. when seedExec.Open() return succ and recursiveExec.Open() returns error, and if this cte is shared by multiple operators, other operator may open seedExec again, which cause resource leaking.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
drop table if exists t, t1, t2;
create table t (id int,name varchar(10));
insert into t values(1,'tt');
create table t1(id int,name varchar(10),name1 varchar(10),name2 varchar(10));
insert into t1 values(1,'tt','ttt','tttt'),(2,'dd','ddd','dddd');
create table t2(id int,name varchar(10),name1 varchar(10),name2 varchar(10),`date1` date);
insert into t2 values(1,'tt','ttt','tttt','2099-12-31'),(2,'dd','ddd','dddd','2099-12-31');
set tidb_mem_quota_query = 7000;
run cte sql for 2000 times (check https://github.com/pingcap/tidb/issues/50337 for detailed sql)

curl 'http://127.0.0.1:10080/debug/zip?seconds=5' --output debug4.zip and search copIteratorTaskSender to check if any goroutine leak.
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix CTE goroutine leak when child.Close() return error

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Feb 20, 2024
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@def88be). Click here to learn what that means.
The diff coverage is 58.6956%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51166   +/-   ##
================================================
  Coverage               ?   71.9898%           
================================================
  Files                  ?       1404           
  Lines                  ?     407634           
  Branches               ?          0           
================================================
  Hits                   ?     293455           
  Misses                 ?      94456           
  Partials               ?      19723           
Flag Coverage Δ
unit 71.9898% <58.6956%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3096% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 02:59:23.198772257 +0000 UTC m=+326051.946395369: ☑️ agreed by XuHuaiyu.
  • 2024-02-20 04:01:39.790617288 +0000 UTC m=+329788.538240399: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 4058740 into pingcap:release-7.5 Feb 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants