-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix CTE goroutine leak when exceeds mem quota (#50828) #51166
executor: fix CTE goroutine leak when exceeds mem quota (#50828) #51166
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51166 +/- ##
================================================
Coverage ? 71.9898%
================================================
Files ? 1404
Lines ? 407634
Branches ? 0
================================================
Hits ? 293455
Misses ? 94456
Partials ? 19723
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #50828
What problem does this PR solve?
Issue Number: close #50337
Problem Summary:
seedExec.Open()
return succ andrecursiveExec.Open()
returns error, and if this cte is shared by multiple operators, other operator may openseedExec
again, which cause resource leaking.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.