-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session/variable: forbid changing @@global.require_secure_transport to 'on' with SEM enabled (#47677) #51207
session/variable: forbid changing @@global.require_secure_transport to 'on' with SEM enabled (#47677) #51207
Conversation
…visible when SEM is on
Co-authored-by: bb7133 <bb7133@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #51207 +/- ##
================================================
Coverage ? 72.1356%
================================================
Files ? 1408
Lines ? 410715
Branches ? 0
================================================
Hits ? 296272
Misses ? 94642
Partials ? 19801
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, djshow832, easonn7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #47677
What problem does this PR solve?
Issue Number: close #47665
Problem Summary:
The configuration for TiDB Cloud dedicated cluster is:
We just provide the
ca.crt
file for the the users to connect the TiDB cluster. Whenrequire_secure_transport = OFF
, there is no problem.But if the user set the value of require_secure_transport to 'ON', the users can not connect to the cluster anymore!
This is because the new configuration require the mysql client to pass all
ca.crt
tls.crt
tls.key
correctly, while the user only have theca.crt
file.What is changed and how it works?
To prevent the user from losing access of the cluster, we can forbid changing
require_secure_transport
system variable to 'on' as a workaround, then the user can not modify it and trigger the issue.Check List
Tests
Modify the config.toml.example:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.